Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw on missing trailing slash #9

Closed
wants to merge 1 commit into from
Closed

Don't throw on missing trailing slash #9

wants to merge 1 commit into from

Conversation

critocrito
Copy link

Hey,

When I omit a trailing slash for the directory name an exception is thrown. Using path.resolve over string concatenation resolves this issue for me.

pihvi added a commit that referenced this pull request Sep 28, 2018
@pihvi
Use path to read dir and allow missing slash
45a393f 
Thanks @critocrito
#9
@pihvi
Copy link
Owner

pihvi commented Sep 28, 2018

Thanks! Great enhancement. It is now available in version 3.2.2.

@pihvi pihvi closed this Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@critocrito @pihvi